Skip to content

Backport translations to stable branches#2232

Merged
juliusknorr merged 1 commit intomasterfrom
translations/backport
May 23, 2022
Merged

Backport translations to stable branches#2232
juliusknorr merged 1 commit intomasterfrom
translations/backport

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 20, 2022

Should fix #2231

Based on https://github.com/nextcloud/docker-ci/blob/master/translations-app/handleAppTranslations.sh#L17-L19

  • Drop this file once stable4 branch is no longer supported as we can use the default stable* then
  • Document the backport behaviour for app developers

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels May 20, 2022
@juliusknorr juliusknorr requested a review from Raudius May 20, 2022 05:24
@juliusknorr juliusknorr merged commit 2aa3683 into master May 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the translations/backport branch May 23, 2022 10:29
@juliusknorr
Copy link
Member Author

Manually triggered and pushed now to all stable branches 🎉

@juliusknorr
Copy link
Member Author

Awesome seems we actually have that documented 4 days ago nextcloud/documentation#8324

@Jerome-Herbinet
Copy link
Member

Hello @juliushaertl thank your for all this.
Do you think it's possible to backport it to NC 23 ?
Best regards,
Jérôme

@Raudius
Copy link
Contributor

Raudius commented Jul 27, 2022

@Jerome-Herbinet

I am not sure that backporting this would do anything since it looks like the translations are coming through to the stable23/stable24 branches already:

8d62155

@Jerome-Herbinet
Copy link
Member

@Raudius
In fact, I just checked the rendering of the loading screen on two instances (NC23 and NC24 with Collabora up to date) and the screen is displayed in French only under NC24 ("Chargement"), while under NC23, we still have a screen written in English ("Loading"). The problem was initialy described in the #2231 issue. Do you understand what can happen ? Thank you for your help in helping me understand things better as a non-developer :-)

@Raudius
Copy link
Contributor

Raudius commented Jul 27, 2022

@Jerome-Herbinet

Some details: this PR makes some changes to signal to the translation updater to also push the translation changes to older versions (24, 23...)

However the translation bot does seem to be extracting translation strings from the older versions (so the master branch translations are used). It turned out the stable23 "Loading" string was missing a space (compared to the master branch)

I have addressed this issue in this PR: #2338

@Jerome-Herbinet
Copy link
Member

Thank you very much for your explanation @Raudius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading message not translated (at least in French) in Nextcloud Office on Nextcloud 23

3 participants