chore: drop dead code from ShareLinkListener#5330
Merged
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
elzody
approved these changes
Feb 2, 2026
Contributor
elzody
left a comment
elzody
left a comment
There was a problem hiding this comment.
I agree, should be fine to remove it. Thanks a lot!
Contributor
|
/backport to stable33 |
Contributor
|
/backport to stable32 |
Contributor
|
/backport to stable31 |
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The return value from this isn't being used so it's a no-op.
I don't think it's needed; I believe nextcloud/auth is mostly used by the front-end for this sort of thing.
If it's needed than it's currently a bug since it's not actually doing anything. ;)
TODO
Checklist