Skip to content

[Bug]: getAccessList in ShareByMailProvider uses incorrect array key #32630

@ASerbinski

Description

@ASerbinski

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Per documentation https://github.com/nextcloud/server/blob/master/lib/private/Share20/Manager.php#L1671 -- share by mail should use the array key "mail". Instead, it is using the array key "public", which collides with array key used in DefaultShareProvider for share by link; https://github.com/nextcloud/server/blob/master/lib/private/Share20/DefaultShareProvider.php#L1368

Change is required here;
https://github.com/nextcloud/server/blob/master/apps/sharebymail/lib/ShareByMailProvider.php#L1211

Steps to reproduce

Not applicable

Expected behavior

ShareByMailProvider should use "mail" as array key.

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

N/A

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions