Remove outdated integrity warning on each page#12418
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 12, 2018
Merged
Conversation
* integrity warning is shown during update and in the admin setup checks * there is also the plan to retire this old way of notification Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
requested review from
blizzz,
kesselb,
nickvergessen,
rullzer,
schiessle and
skjnldsv
blizzz
approved these changes
Nov 12, 2018
skjnldsv
approved these changes
Nov 12, 2018
MorrisJobke
added
4. to release
MorrisJobke
deleted the
bugfix/noid/do-not-show-integrity-warning-always
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is also quite often the request on how to disable the integrity check warning. I guess it is fine to show this in the setup checks only and not on every single page.