Skip to content

[stable14] Fix missing quickaccess favorite folder on add #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Nov 14, 2018
Merged

[stable14] Fix missing quickaccess favorite folder on add #12441

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13a22c7
fix for favorites-quickaccess: newly added folders dont show up when …
newhinton Aug 27, 2018
94a5ffe
Update PHPDoc to fix typos
MorrisJobke Nov 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/files/appinfo/routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@
'url' => '/api/v1/toggleShowFolder/{key}',
'verb' => 'POST'
],
[
'name' => 'API#getNodeType',
'url' => '/api/v1/quickaccess/get/NodeType',
'verb' => 'GET',
],
]
]
);
Expand Down
12 changes: 12 additions & 0 deletions apps/files/lib/Controller/ApiController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,5 +292,17 @@ public function toggleShowFolder(int $show, string $key) {
return $response;
}

/**
* Get sorting-order for custom sorting
*
* @NoAdminRequired
*
* @param String
Copy link
Copy Markdown
Contributor

@kesselb kesselb Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String => string (http://docs.phpdoc.org/guides/types.html)

* @return String
*/
Copy link
Copy Markdown
Contributor

@kesselb kesselb Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @throws NotFoundException because get($folderpath)

server/lib/public/Files/Folder.php

Lines 77 to 85 in 39bb32a

/**
* Get the node at $path
*
* @param string $path relative path of the file or folder
* @return \OCP\Files\Node
* @throws \OCP\Files\NotFoundException
* @since 6.0.0
*/
public function get($path);
could throw it.

public function getNodeType($folderpath) {
$node = $this->userFolder->get($folderpath);
return $node->getType();
}

}