Fix navigation layout for items that are added on a re-render#12481
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 16, 2018
Merged
Fix navigation layout for items that are added on a re-render#12481MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
nickvergessen
added
bug
design
nickvergessen
requested review from
MorrisJobke,
jancborchardt,
juliusknorr and
skjnldsv
skjnldsv
approved these changes
Nov 16, 2018
Member
|
Fix #12464 ? |
Member
Already added ;) |
rullzer
approved these changes
Nov 16, 2018
Member
|
I don't get it. For me the code is locally executed but the result still looks wrong:
I refreshed multiple times, reinstalled, used different browsers ... and still - the newly added apps are still rendered wrongly. So this does not fix #12481 somehow. for me. |
skjnldsv
force-pushed
the
bugfix/noid/fix-navigation-layout-of-new-items
branch
from
10cd800 to
4604a74
Compare
skjnldsv
approved these changes
Nov 16, 2018
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Done.
The span is next to the a, not within it.
I also fixed the size of the apps icons that did not reflect what the php was initially outputting.
Signed-off-by: Joas Schilling <coding@schilljs.com>
skjnldsv
force-pushed
the
bugfix/noid/fix-navigation-layout-of-new-items
branch
from
4604a74 to
44b0d39
Compare
MorrisJobke
deleted the
bugfix/noid/fix-navigation-layout-of-new-items
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was not visible until #12153
Now it looks awkward with the externals app
Fixes #12464