Make number of file list entries depending on the width for grid view#12515
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 19, 2018
Merged
Make number of file list entries depending on the width for grid view#12515MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
juliusknorr
added
design
juliusknorr
requested review from
MorrisJobke,
danxuliu,
jancborchardt and
skjnldsv
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
papercut/12295/grid-view-lazy-loading
branch
from
42b7c7c to
eb03960
Compare
skjnldsv
reviewed
Nov 18, 2018
skjnldsv
approved these changes
Nov 18, 2018
MorrisJobke
approved these changes
Nov 19, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code makes sense and works 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12295
This PR adds calculation of the number of file list entries for the available container size in grid view.