Fix the config key on the sharing expire checkbox#24341
Conversation
We don't use `shareapi_internal_enforce_expire_date` anywhere. `shareapi_enforce_internal_expire_date` is the one we want. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
julien-nc,
juliusknorr,
rullzer and
skjnldsv
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable18 |
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Took you long enough to find my error!
|
Is this maybe related to #19786? |
Possibly. Do you have a dev instance to check? |
ChristophWurst
added
4. to release
no, sorry |
|
I looks like the code takes the default sharing date still. Like I disabled the option and I a default expiration date of 7d. So I don't think this changes anything for that ticket. This PR is really just about that one specific checkbox. |
OK, thanks for looking into it anyway. There was a chance 😉 |
|
The backport to stable18 failed. Please do this backport manually. |
|
stable18 backport is in #24481 |
6 participants
We don't use
shareapi_internal_enforce_expire_dateanywhere.shareapi_enforce_internal_expire_dateis the one we want.Regression of #17725.
On master you can't actually set/unset "Enforce expiration date". The js will update some config value, but it's the wrong one. Hence the expiration date was always enforced.