fix CacheJail::filterCacheEntry when entry is already filtered#25093
Closed
icewind1991 wants to merge 1 commit intomasterfrom
Closed
fix CacheJail::filterCacheEntry when entry is already filtered#25093icewind1991 wants to merge 1 commit intomasterfrom
icewind1991 wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Member
|
Is there no way to not call it then? because then we can type hint it as array instead of doing it that way. |
Member
Author
|
I'm not sure what code path triggers this, I only have the error being logged that the method is being called with Adding a type hint would be nice in the long term but would require either being able to reproduce things locally or debug patch cycles to properly figure out where this issue comes from. |
This was referenced Jan 14, 2021
Merged
Merged
Merged
Merged
Member
|
Master is Nextcloud 22 now. |
rullzer
approved these changes
Feb 11, 2021
|
This error also appears on NC 20 and my provider does not support MySQL 8 yet. |
Member
|
@icewind1991 a wild conflict appears |
Member
Author
|
No longer needed with #25136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Appelman robin@icewind.nl