Add "composer.lock" for acceptance tests to git#25176
Merged
MorrisJobke merged 1 commit intomasterfrom Jan 18, 2021
Merged
Conversation
As "composer.lock" was not versioned the dependencies had to be resolved everytime that the acceptance tests run, which took some precious time. Besides that the dependency versions were also tightened for better control. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1419: failuremariadb10.4-php7.4Show full log |
rullzer
approved these changes
Jan 18, 2021
Member
This was referenced Jan 18, 2021
Member
|
BTW: this went from 7h 5m 24s to 5h 0m 51s. So it reduced the time of our CI pipeline by 30%. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As "composer.lock" was not versioned the dependencies had to be resolved everytime that the acceptance tests run, which took some precious time*.
Besides that the dependency versions were also tightened for better control.
*Apparently up to eleven minutes (
Updating dependencies (including require-dev)at 5s, next log at 670s 😱) so I think that deserves a backport.