Merged
Conversation
juliusknorr
requested review from
ChristophWurst,
MorrisJobke,
kesselb and
rullzer
ChristophWurst
approved these changes
Apr 21, 2021
kesselb
approved these changes
Apr 21, 2021
rullzer
reviewed
Apr 21, 2021
Member
|
Please squash and rebase :) |
| * @param \Exception|null $previous | ||
| * @since 22.0.0 | ||
| */ | ||
| public function __construct($message, $hint = '', $code = 0, \Exception $previous = null) { |
Member
There was a problem hiding this comment.
Suggested change
| public function __construct($message, $hint = '', $code = 0, \Exception $previous = null) { | |
| public function __construct(string $message, string $hint = '', int $code = 0, ?\Exception $previous = null) { |
Can we do this or will it do boom?
Member
There was a problem hiding this comment.
Will do boom because of the exceptions that extend it and then they don't match anymore 🙈
Member
|
So, I know you just string replaced, but the import order is now not alphabetically anymore, @kesselb will be sad |
Merged
Member
|
@juliushaertl Mind to fix the comments? |
Member
|
Member
|
also conflicts. move to 23? |
Member
Author
|
Yes, lets move that. |
Member
|
@juliushaertl Mind if I take over this PR? |
Member
Author
|
@gary-kim Sure, feel free to go ahead with it :) |
gary-kim
force-pushed
the
techdebt/hint-exception-ocp
branch
5 times, most recently
from
4cea5b9 to
e7089dd
Compare
Member
|
Rebased, reordered the imports, and addressed the comments that I could. |
gary-kim
requested review from
ChristophWurst,
MorrisJobke,
kesselb,
nickvergessen and
rullzer
This comment has been minimized.
This comment has been minimized.
gary-kim
force-pushed
the
techdebt/hint-exception-ocp
branch
from
e7089dd to
61806dc
Compare
Member
|
Rebased |
ChristophWurst
approved these changes
Jun 30, 2021
This comment has been minimized.
This comment has been minimized.
gary-kim
force-pushed
the
techdebt/hint-exception-ocp
branch
from
61806dc to
3302a20
Compare
Signed-off-by: Gary Kim <[email protected]>
gary-kim
force-pushed
the
techdebt/hint-exception-ocp
branch
from
3302a20 to
b78f3a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are plenty of exceptions in OCP that are extending from it and it is also used by some apps:
Makes psalm more happy when running with only the public namespace