Make security warning stand out more#27605
Merged
LukasReschke merged 2 commits intomasterfrom Jun 23, 2021
Merged
Conversation
The security warning is currently being ignored by too many users as it's part of the text and not visually distinct. Ref #26944 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
Member
Author
|
@jancborchardt Any opinions? We received several reports that this is being ignored by users which is bad. (in combination with a targeted phishing attack this could result in an account takeover) |
blizzz
approved these changes
Jun 22, 2021
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
jancborchardt
approved these changes
Jun 23, 2021
nickvergessen
approved these changes
Jun 23, 2021
Member
So mobile clients and I think also the desktop cheat on this request and show a device name as user agent. |
Member
Author
|
Failures look unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security warning is currently being ignored by too many users as it's part of the text and not visually distinct.
Before:
After:
Fixes #26943