Filepicker - hide empty create action box if creation is not allowed#28020
Closed
Filepicker - hide empty create action box if creation is not allowed#28020
Conversation
npmbuildbot-nextcloud
bot
force-pushed
the
enh/15966/empty-action-box-fix
branch
from
6f259cc to
371168a
Compare
szaimen
force-pushed
the
enh/15966/empty-action-box-fix
branch
from
371168a to
e501a89
Compare
npmbuildbot-nextcloud
bot
force-pushed
the
enh/15966/empty-action-box-fix
branch
from
e501a89 to
3d60089
Compare
szaimen
force-pushed
the
enh/15966/empty-action-box-fix
branch
2 times, most recently
from
431eece to
3062070
Compare
szaimen
commented
Jul 17, 2021
| var newButton = self.$filePicker.find('.actions.creatable .button-add') | ||
| if (type === self.FILEPICKER_TYPE_CHOOSE && !options.allowDirectoryChooser) { | ||
| newButton.hide() | ||
| self.$filePicker.find('.actions.creatable').hide() |
Contributor
Author
There was a problem hiding this comment.
Actually, none of those commands (neither the old nor the new) seem to have any effect in my testing so I really don't know how to fix this from the javascript side...
szaimen
force-pushed
the
enh/15966/empty-action-box-fix
branch
from
80a812e to
fa61c98
Compare
Contributor
Author
|
fa61c98 Fixes #15966 via CSS but has the unwanted side effect that it also changes the style of the button when the button is visible... (I unfortunately didn't find any solution that fixes the initial problem and this visual regression at the same time...) CSS Solution for #15966
New Problem after applying that css style change
I don't think that its too bad but whats your opinion on that? |
szaimen
added
help wanted
3. to review
Merged
Contributor
Author
|
/rebase |
Signed-off-by: szaimen <[email protected]>
Signed-off-by: szaimen <[email protected]>
nextcloud-command
force-pushed
the
enh/15966/empty-action-box-fix
branch
from
fa61c98 to
81b043d
Compare
Merged
Merged
Contributor
Author
|
Superseded by #33297 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15966
Signed-off-by: szaimen [email protected]