Debug log what happens during reminders processing#28703
Merged
ChristophWurst merged 1 commit intomasterfrom Jun 2, 2022
Merged
Debug log what happens during reminders processing#28703ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
julien-nc
approved these changes
Sep 3, 2021
| * @throws NotificationTypeDoesNotExistException | ||
| */ | ||
| public function processReminders():void { | ||
| public function processReminders() :void { |
Member
There was a problem hiding this comment.
This could be applied to all methods in this file 😁.
Merged
ChristophWurst
force-pushed
the
enhancement/caldav-reminders-logging
branch
from
9f352df to
2473433
Compare
| public function processReminders():void { | ||
| public function processReminders() :void { | ||
| $reminders = $this->backend->getRemindersToProcess(); | ||
| $this->logger->debug(sprintf("%d reminders to process", count($reminders))); |
Member
There was a problem hiding this comment.
Suggested change
| $this->logger->debug(sprintf("%d reminders to process", count($reminders))); | |
| $this->logger->debug(sprintf('%d reminders to process', count($reminders))); |
Member
There was a problem hiding this comment.
Or you use:
Suggested change
| $this->logger->debug(sprintf("%d reminders to process", count($reminders))); | |
| $this->logger->debug('{reminders} reminders to process', ['reminders' => count($reminders)]); |
Member
There was a problem hiding this comment.
So I debugged the one on or company instance a bit:
if (!is_string($calendarData)) {
\OC::$server->getLogger()->error(
'Debugging: ReminderService::parseCalendarData: '.
(is_resource($reminder['calendardata'])
? 'is_resource'
: '!is_resource') .
'id' . $reminder['id'] .
'calendar_id' . $reminder['calendar_id'] .
'object_id' . $reminder['object_id'] .
'recurrence_id' . $reminder['recurrence_id'],
['app' => 'dav-nickvergessen-debugging']
);
}Debugging: ReminderService::parseCalendarData:
!is_resource
id 68522
calendar_id 119
object_id 0
recurrence_id 1639650600
So the reminder is not linked with any object?
Member
There was a problem hiding this comment.
Do you mind logging $reminder['is_recurring'] and $reminder['is_recurrence_exception'] as well? I feel this may be the issue.
Member
There was a problem hiding this comment.
is_recurring true
is_recurrence_exception false
Merged
Merged
ChristophWurst
force-pushed
the
enhancement/caldav-reminders-logging
branch
from
2473433 to
7ea99d5
Compare
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/caldav-reminders-logging
branch
from
7ea99d5 to
58f7a15
Compare
tcitworld
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nextcloud/calendar#3000