Do not create local world-readable files and directories per default#29448
Closed
Flowdalic wants to merge 1 commit intonextcloud:masterfrom
Closed
Do not create local world-readable files and directories per default#29448Flowdalic wants to merge 1 commit intonextcloud:masterfrom
Flowdalic wants to merge 1 commit intonextcloud:masterfrom
Conversation
szaimen
requested review from
a team,
CarlSchwan,
come-nc and
icewind1991
and removed request for
a team
icewind1991
approved these changes
Nov 11, 2021
Starting with e5dc1a8 ("Set umask before operations that create local files") Nextcloud would create local files and directories with their permission set to world readable. While you can protect access to nextcloud's data/ directory by -x'ing it, when it comes to permissions and security, a defensive approach is always preferable. Hence this changes the used umask from 022 to 027. This partly addresses nextcloud#29041. Signed-off-by: Florian Schmaus <flo@geekplace.eu>
Flowdalic
force-pushed
the
umask-0027
branch
from
ec83b6e to
78edee3
Compare
Author
|
Rebased on the latest master and added DCO. Please approve the workflows. Thanks. |
Merged
Merged
come-nc
reviewed
May 5, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
My preference would really go toward leaving umask alone, or at least make it an option.
Contributor
Contributor
|
Yes exactly, I forgot we had already a PR for this. @icewind1991 Could you review it? |
Contributor
|
obsoleted by #32723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with e5dc1a8 ("Set umask before operations that create
local files") Nextcloud would create local files and directories with
their permission set to world readable. While you can protect access
to nextcloud's data/ directory by -x'ing it, when it comes to
permissions and security, a defensive approach is always
preferable. Hence this changes the used umask from 022 to 027.
This partly addresses #29041.