allow to override prefers-color-scheme via url param for guests#29940
allow to override prefers-color-scheme via url param for guests#29940jonathanmmm wants to merge 4 commits intonextcloud:masterfrom
Conversation
|
Could solve this issue: #29699 |
|
/compile amend / |
using ?force-color-scheme=light should make the theme light and ?force-color-scheme=dark should make it dark. Useful for iframes to match a website theme and to send a specific theme to a guest. Signed-off-by: jonathanmmm <32403139+jonathanmmm@users.noreply.github.com>
cb5725d to
06cd8e2
Compare
|
Ok, somehow it doesn't do anything. If I put into the third line Does somebody know, if Don't know how these js files with the super long lines work, are they compiled or do I have to change them too? This pull and commit seem to made prefer-color-scheme possible in the first place https://github.com/nextcloud/server/pull/21366/files |
|
@CarlSchwan If you have motivation+time, we could takle this feature together. |
|
Research: 2916402 and change it so that line 27-30 the value in line 29 is not changed if url parameter is given |
|
@CarlSchwan It is working now when dark mode is enabled in the system (forcing light mode), but not the other way around and I don't know. I even tried and replaced every |
|
As there is no feedback since a while I will close this ticket. Thanks for the interest in Nextcloud and the effort put into this! 🙇 |
using ?force-color-scheme=light should make the theme light and ?force-color-scheme=dark should make it dark.
Useful for iframes to match a website theme and to send a specific theme to a guest.
I couldn't test it locally, as it seems that javascript is somehow like compiled (and the src folder is missing for example) and have no developer setup. If needed, I can set one up.
My first pull request to nextcloud, if you have feedback how to make it better next time, tell me.