Conversation
Pytal
added
enhancement
3. to review
Pytal
requested review from
CarlSchwan and
PVince81
and removed request for
a team
This was referenced Mar 1, 2022
Pytal
force-pushed
the
feat/account-migrator
branch
from
11d6725 to
664e827
Compare
come-nc
requested changes
Mar 1, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
This PR should also take care of registering the migrator.
Pytal
force-pushed
the
feat/account-migrator
branch
2 times, most recently
from
7014a0f to
5e345b5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Pytal
force-pushed
the
feat/account-migrator
branch
2 times, most recently
from
5a343ed to
ec15a1e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Pytal
force-pushed
the
feat/account-migrator
branch
2 times, most recently
from
3409d61 to
0f1ab1b
Compare
This was referenced Mar 8, 2022
Pytal
force-pushed
the
feat/account-migrator
branch
from
0f1ab1b to
1255b31
Compare
Pytal
force-pushed
the
feat/account-migrator
branch
from
4acf23c to
2b96e0b
Compare
Member
Author
|
Ready for review after all required PRs have got in |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/account-migrator
branch
from
2b96e0b to
6a99d3a
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/account-migrator
branch
from
6a99d3a to
ad31cfe
Compare
come-nc
reviewed
Mar 21, 2022
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
I think that as this migrator is now in the settings app it should import/export from a folder named after settings Application::APP_ID.
This makes it consistent with other migrators, and avoids people taking inspiration from this migrator to put things at the archive export root folder.
artonge
approved these changes
Mar 21, 2022
Pytal
force-pushed
the
feat/account-migrator
branch
from
abd8395 to
39386a1
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
feat/account-migrator
branch
from
39386a1 to
85123f9
Compare
come-nc
approved these changes
Mar 22, 2022
This was referenced Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/nextcloud/user_migration migrator which enables export and import of a user's account info
Requires