Fix the logger that is imported for critical actions#31454
Merged
Conversation
skjnldsv
reviewed
Mar 4, 2022
skjnldsv
reviewed
Mar 4, 2022
CarlSchwan
force-pushed
the
fix/audit-log-critical
branch
from
84d2791 to
44c7065
Compare
CarlSchwan
force-pushed
the
fix/audit-log-critical
branch
from
44c7065 to
a307c9e
Compare
skjnldsv
approved these changes
Mar 4, 2022
Member
Author
|
Unit tests are failing but I'm not sure it's caused by this PR: |
Member
The "Set up php 7.4" command errors:
I assume this is a temporary bug with actions? But this here is not:
|
CarlSchwan
added
3. to review
nickvergessen
approved these changes
Mar 10, 2022
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
As this fixes a bug, we need to backport it, right?
Member
Author
yes |
This use a new interface AuditLogger that makes it easier to seperate the roles of the various loggers and enforce that we don't use the wrong one by mistake. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/audit-log-critical
branch
from
b484e84 to
3e0c42e
Compare
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
skjnldsv
added
4. to release
Contributor
|
This PR might have broken |
Member
|
Add the import in 3e0c42e#diff-26f1e4805b227aa0936eaf6b5492ca8b166f852322243fb5d37b0d27e4c30f95R47 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's just using the normal psr logger
Needed for nextcloud/groupfolders#1917