do not forget DB table prefix with truncate query by blizzz · Pull Request #31620 · nextcloud/server

blizzz · 2022-03-18T16:04:36Z

as used in LDAP's AbstractMapping::clear() method
and in Comment's ManagerTest::setUp()
fixes a DB Exception with Oracle

- as used in LDAP's AbstractMapping::clear() method - and in Comment's ManagerTest::setUp() - fixes a DB Exception with Oracle Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

come-nc · 2022-03-21T10:46:55Z

How does one know when PREFIX is needed and when not?
We have other calls on the IDBConnection that do not contain it:
https://github.com/nextcloud/server/blob/master/apps/user_ldap/lib/Migration/Version1130Date20211102154716.php#L184

blizzz · 2022-03-21T10:50:17Z

How does one know when PREFIX is needed and when not? We have other calls on the IDBConnection that do not contain it: https://github.com/nextcloud/server/blob/master/apps/user_ldap/lib/Migration/Version1130Date20211102154716.php#L184

It is not needed when using the query builder.

nickvergessen

That doc block thou 🤪

Maybe we fix that properly?

blizzz · 2022-03-22T10:00:30Z

/backport to stable21

blizzz · 2022-03-22T10:01:00Z

/backport to stable20

backportbot-nextcloud · 2022-03-22T11:08:39Z

The backport to stable20 failed. Please do this backport manually.

backportbot-nextcloud · 2022-03-22T11:08:41Z

The backport to stable21 failed. Please do this backport manually.

blizzz · 2022-03-22T14:11:48Z

/backport to stable23

blizzz · 2022-03-22T16:26:41Z

/backport to stable22

blizzz · 2022-03-22T17:09:16Z

/backport to stable21

blizzz · 2022-03-23T12:04:41Z

/backport to stable20

backportbot-nextcloud · 2022-03-23T12:11:37Z

The backport to stable20 failed. Please do this backport manually.

do not forget DB table prefix with truncate query

4656753

- as used in LDAP's AbstractMapping::clear() method - and in Comment's ManagerTest::setUp() - fixes a DB Exception with Oracle Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

blizzz added bug 3. to review Waiting for reviews feature: ldap labels Mar 18, 2022

blizzz added this to the Nextcloud 24 milestone Mar 18, 2022

blizzz requested review from a team, PVince81, come-nc and nickvergessen and removed request for a team March 18, 2022 16:04

come-nc approved these changes Mar 21, 2022

View reviewed changes

nickvergessen approved these changes Mar 21, 2022

View reviewed changes

PVince81 merged commit 6fa51be into master Mar 22, 2022

PVince81 deleted the fix/noid/truncate-oracle branch March 22, 2022 09:46

This comment was marked as resolved.

Sign in to view

backportbot-nextcloud bot added the backport-request label Mar 22, 2022