contact hyperlink issue fixed

[devsekar-1992]

I fixed the issue for this open issue #24807

[szaimen]

Works! Thanks for fixing this :)

[Pytal]

Could we handle the case when contact.topAction is not defined?

[szaimen]

Could we handle the case when contact.topAction is not defined?

@devsekar-1992?

[devsekar-1992]

Could we handle the case when contact.topAction is not defined?

No,it's not handled contact.topAction object flag. If we need to handle that scenario,we need to move that div into the action div area

I saw the entire object for contact shows in the menu popover, profile URL object doesn't have any data. Either we need to check the entire contact object why profile objects are empty or add same condition in above image to my changes.

Please suggest your idea for this fix

[Pytal]

@devsekar-1992 from line 30 of https://github.com/devsekar-1992/server/blob/contact-popover-issue/core/src/OC/contactsmenu/contact.handlebars something like the below should work

{{else if contact.topAction}}
	<a class="body" href="{{contact.topAction.hyperlink}}">
		<div class="full-name">{{contact.fullName}}</div>
		<div class="last-message">{{contact.lastMessage}}</div>
		<div class="email-address">{{contact.emailAddresses}}</div>
	</a>
	<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}">
		<img src="{{contact.topAction.icon}}" alt="{{contact.topAction.title}}">
	</a>
{{else}}
	<div class="body">
		<div class="full-name">{{contact.fullName}}</div>
		<div class="last-message">{{contact.lastMessage}}</div>
		<div class="email-address">{{contact.emailAddresses}}</div>
	</div>
{{/if}}
{{#if contact.hasTwoActions}}

[devsekar-1992]

@devsekar-1992 from line 30 of https://github.com/devsekar-1992/server/blob/contact-popover-issue/core/src/OC/contactsmenu/contact.handlebars something like the below should work

{{else if contact.topAction}}
	<a class="body" href="{{contact.topAction.hyperlink}}">
		<div class="full-name">{{contact.fullName}}</div>
		<div class="last-message">{{contact.lastMessage}}</div>
		<div class="email-address">{{contact.emailAddresses}}</div>
	</a>
	<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}">
		<img src="{{contact.topAction.icon}}" alt="{{contact.topAction.title}}">
	</a>
{{else}}
	<div class="body">
		<div class="full-name">{{contact.fullName}}</div>
		<div class="last-message">{{contact.lastMessage}}</div>
		<div class="email-address">{{contact.emailAddresses}}</div>
	</div>
{{/if}}
{{#if contact.hasTwoActions}}

Ok I will do

[Pytal]

Suggested change

	<a class="body" href="{{contact.topAction.hyperlink}}">
	<div class="full-name">{{contact.fullName}}</div>
	<div class="last-message">{{contact.lastMessage}}</div>
	<div class="email-address">{{contact.emailAddresses}}</div>
	</a>
	<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}">
	<img src="{{contact.topAction.icon}}" alt="{{contact.topAction.title}}">
	</a>
	<a class="body" href="{{contact.topAction.hyperlink}}">
	<div class="full-name">{{contact.fullName}}</div>
	<div class="last-message">{{contact.lastMessage}}</div>
	<div class="email-address">{{contact.emailAddresses}}</div>
	</a>
	<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}">
	<img src="{{contact.topAction.icon}}" alt="{{contact.topAction.title}}">
	</a>

Indentation fix

[devsekar-1992]

Thanks for indent

[Pytal]

/compile amend /

[szaimen]

@devsekar-1992 could you please fix dco, rebase your branch on top of master and compile and commit the js? Thank you! :)

[devsekar-1992]

@devsekar-1992 could you please fix dco, rebase your branch on top of master and compile and commit the js? Thank you! :)

I did dco but still showing error

[szaimen]

I did dco but still showing error

---

How to fix it:

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line.
In your local branch, run: git rebase HEAD~9 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin contact-popover-issue

[devsekar-1992]

I did dco but still showing error

How to fix it:

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by checking out the pull request locally via command line. In your local branch, run: git rebase HEAD~9 --signoff Force push your changes to overwrite the branch: git push --force-with-lease origin contact-popover-issue

After rebase and push ,shows everything up-to-date

[devsekar-1992]

@szaimen please use below pull request

#31824

[szaimen]

Superseded by #31824