[stable23] Update autoloaders and Node package-lock.json

[MichaIng]

Autoloaders update is required to solve Drone checkers, package-lock.json update to solve all Node checks.

I simply did:

bash build/autoloaderchecker.sh
npm i

PHP version was 8.1, in case it is relevant.

[MichaIng]

Strange, package-lock.json is still not in sync:

npm ERR! Missing: react@1.0.0 from lock file
npm ERR! Missing: react-dom@18.0.0 from lock file
npm ERR! Missing: scheduler@0.21.0 from lock file

Looks like those are in package-lock.json but not in package.json, i.e. also no dependencies anymore? I'll try to remove it before npm i.

Ah, now I see a warning, looks like I need to downgrade Node and npm:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@nextcloud/axios@1.9.0',
npm WARN EBADENGINE   required: { node: '^14.0.0', npm: '^7.0.0' },
npm WARN EBADENGINE   current: { node: 'v17.6.0', npm: '8.5.3' }
npm WARN EBADENGINE }

EDIT: Doesn't change anything. Strange is also that I do not see this error when running npm ci locally with any version. Rebuilding package-lock.json from scratch of course means a lot of bumped dependencies, what we do not want here.

These errors btw showed up the first time with this commit: b404e3f
There must have something changed externally and/or with the GitHub runners environment?

Also I do not understand the error, the two react modules are actual dependencies, e.g.:

    "node_modules/linkifyjs": {
      "version": "2.1.9",
      "resolved": "https://registry.npmjs.org/linkifyjs/-/linkifyjs-2.1.9.tgz",
      "integrity": "sha512-74ivurkK6WHvHFozVaGtQWV38FzBwSTGNmJolEgFp7QgR2bl6ArUWlvT4GcHKbPe1z3nWYi+VUdDZk16zDOVug==",
      "peerDependencies": {
        "jquery": ">= 1.11.0",
        "react": ">= 0.14.0",
        "react-dom": ">= 0.14.0"
      }
    },

And scheduler does exist neither in package-lock.json nor in package.json 😕.

Not idea what is wrong with the CI node checks, I cannot replicate anything locally, help needed.

[szaimen]

I guess we need some help here. Maybe @artonge has some ideas how to solve this? :)

[artonge]

The issue might come from npm v8.6 npm/cli#4684

[MichaIng]

Ah, so the local build was not the issue, but since the workflows installs npm i -g npm@">=7.0.0". This fits to the fact that the CI failures happened the first time without any failing commit/PR merged.

• Fix is on the way, to be released this week: fix(arborist): when reloading an edge, also refresh overrides npm/cli#4709
• rebase

[blizzz]

Please rerun the npm step with npm ci for CI

[MichaIng]

Okay worked now. The three Node modules have now been added to package-lock.json. Please someone with more insights into Node dependencies have a look whether those are the intended versions.

Dependency tree seems to be:

• linkifyjs
  • react >=0.14.0 => 18.0.0
  • react-dom >=0.14.0 => 18.0.0
    • scheduler ^0.21.0 => 0.21.0

[blizzz]

@skjnldsv ^

[skjnldsv]

@skjnldsv ^

Honestly can't tell. If linkifyjs requires peerDeps, so be it 🤷