Detect leading spaces in config files#33447
Merged
Conversation
skjnldsv
approved these changes
Aug 3, 2022
CarlSchwan
approved these changes
Aug 3, 2022
Member
Author
|
the tests fail, maybe the bootstrapping thing is generating files like I did... hope it's not a can of worms |
Member
Author
|
ok, I suspect that maybe something else during the tests is triggering an output and making I'll add a condition to detect testing also |
Because those will cause PHP to output to stdout and will cause unrelated error messages. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
fcffdb7 to
89cb450
Compare
Member
Could also only check that if header_sent() was false before loading the config files |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because those will cause PHP to output to stdout and will cause
unrelated error messages.
Steps to reproduce:
<?phpBefore: internal server error with mysterious errors in the log about ini settings that cannot be set at this stage
After: explicit error about the invalid file, both in occ and web UI
Background: I lost some time with this, believing that an app was broken. In my setup I have a bash script that generates the sidecar config files using
cat <<and I mistakenly indented the contents of the file