[Fix]: scan-app-data conversion#35935
Conversation
szaimen
requested review from
a team,
ArtificialOwl,
ChristophWurst,
blizzz and
icewind1991
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Superseeded by #32059 |
No. This is about apps/files/lib/Command/ScanAppData.php. You linked the PR that fixed apps/files/lib/Command/Scan.php. |
|
Sorry about that |
|
Should I squash and force push or it it fine like this? (I used only the browser and my phone for these changes 🤓 (and I tested them locally)) |
Please squash your commits. |
Adapted from sugestions by @Hiyoal in nextcloud#34283 and @st3iny in nextcloud#35935. See nextcloud#34283 (comment) and nextcloud#35935 (comment). Closes nextcloud#34283. Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: EWouters <6179932+EWouters@users.noreply.github.com>
|
Not sure if this is CI flakes: From https://github.com/EWouters/server
* branch patch-1 -> FETCH_HEAD
* [new branch] patch-1 -> pr/patch-1
warning: 9d07ec5a96d7995785f6d3d377024ba09977cb91:.gitmodules, multiple configurations found for 'submodule.3rdparty.path'. Skipping second one!
warning: 9d07ec5a96d7995785f6d3d377024ba09977cb91:.gitmodules, multiple configurations found for 'submodule.3rdparty.url'. Skipping second one!
Fetching submodule 3rdparty
fatal: remote error: upload-pack: not our ref 03c3817ff132653c794fd04410977952f69fd614
Errors during submodule fetch:
3rdparty
Error: Process completed with exit code 1.I can't change the name of the branch without opening a new PR, or is that not the problem? Edit: Is CI perhaps not compatible with the Github CLI utility? |
|
I restarted failed tests. This might be a transient failure. |
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
LGTM! Cypress failures are unrelated.
|
/backport to stable25 |
|
/backport to stable24 |
ChristophWurst
added
4. to release
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Adapted from sugestions by @Hiyoal in #34283 and @st3iny in #35935. See #34283 (comment) and #35935 (comment). Closes #34283. Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: EWouters <6179932+EWouters@users.noreply.github.com>
|
/backport to stable24 |
Adapted from sugestions by @Hiyoal in #34283 and @st3iny in #35935. See #34283 (comment) and #35935 (comment). Closes #34283. Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: EWouters <6179932+EWouters@users.noreply.github.com>
Adapted from sugestions by @Hiyoal in #34283 and @st3iny in #35935. See nextcloud/server#34283 (comment) and nextcloud/server#35935 (comment). Closes #34283. Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud> Signed-off-by: EWouters <6179932+EWouters@users.noreply.github.com>
7 participants
Adapted from sugestions by @Hiyoal in #34283 and @st3iny in #35935.
See #34283 (comment)
and #35935 (comment).
Closes #34283.
Co-authored-by: Richard Steinmetz richard@steinmetz.cloud
Signed-off-by: EWouters 6179932+EWouters@users.noreply.github.com
Summary
Checklist