[stable25] Fix github action "performance-8.0" when PR is from a fork.#36243
Merged
nickvergessen merged 1 commit intostable25from Jan 20, 2023
Merged
[stable25] Fix github action "performance-8.0" when PR is from a fork.#36243nickvergessen merged 1 commit intostable25from
nickvergessen merged 1 commit intostable25from
Conversation
There is an assumption that the PR is from the same remote as the base it is being merged into. This is fixed so that instead of doing a `git fetch origin`, it now fetches from the `clone_url` of the PR head. Signed-off-by: Peter Serwylo <[email protected]>
Contributor
|
profiler still fails, not sure why |
Member
|
That will be fixed in #36246 |
nickvergessen
approved these changes
Jan 20, 2023
come-nc
approved these changes
Jan 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #35192