fix: Validate that we have a proper distributed cache configured#41354
Merged
juliusknorr merged 1 commit intomasterfrom Nov 10, 2023
Merged
fix: Validate that we have a proper distributed cache configured#41354juliusknorr merged 1 commit intomasterfrom
juliusknorr merged 1 commit intomasterfrom
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
a team,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
Altahrim
approved these changes
Nov 9, 2023
solracsf
approved these changes
Nov 10, 2023
8 tasks
Member
|
/backport to stable27 |
Member
|
/backport to stable26 |
Member
Author
|
Failures unrelated |
This was referenced Nov 10, 2023
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle instances where there is
We cannot detect if there is a redis distributed cache configured but the cache is not shared, in this case an error like "Missing metadata for chunked upload" is still expected and points out an architectural issue of the instance setup. I extended the error message a bit there to be more clear.
Fixes #41198