fix(files_sharing): Fallback to old style clipboard copy for internal links#45593
Closed
joshtrichards wants to merge 2 commits intomasterfrom
Closed
fix(files_sharing): Fallback to old style clipboard copy for internal links#45593joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Member
Author
|
/compile amend / |
Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
jtr/fix-40666-fallback-copy
branch
from
831a7a9 to
da793b5
Compare
susnux
reviewed
May 31, 2024
| if (window.isSecureContext) { | ||
| await navigator.clipboard.writeText(this.internalLink) | ||
| } else { // nothing to lose by trying the fallback | ||
| document.execCommand('copy') |
Contributor
There was a problem hiding this comment.
Is the link selected in this case?
(Another fallback would be window.prompt(t('Please copy the link manually'), this.internalLink))
Contributor
|
Correct commit scope would be |
This comment was marked as outdated.
This comment was marked as outdated.
joshtrichards
changed the title
Member
Author
|
/compile amend / |
Signed-off-by: Josh <josh.t.richards@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
jtr/fix-40666-fallback-copy
branch
from
6a5aabf to
7a5e967
Compare
|
How can I compile nextcloud with this fix? |
susnux
reviewed
Oct 10, 2024
| async copyLink() { | ||
| try { | ||
| await navigator.clipboard.writeText(this.internalLink) | ||
| if (window.isSecureContext) { |
Contributor
There was a problem hiding this comment.
Should not be needed as this throws if not available.
So all it takes: in the catch block add a window promt.
Member
Author
|
Closing. Replaced by #49141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist