[stable29] fix(webauthn): Increase database column for public key id#47247
Merged
[stable29] fix(webauthn): Increase database column for public key id#47247
Conversation
backportbot
bot
added
bug
3. to review
susnux
force-pushed
the
backport/47240/stable29
branch
2 times, most recently
from
a806c0c to
264f29e
Compare
susnux
approved these changes
Aug 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
backport/47240/stable29
branch
from
264f29e to
4bd1937
Compare
sorbaugh
approved these changes
Aug 29, 2024
Contributor
|
Cypress is unrelated - someone wants to force merge? Otherwise we need to restart all cypress runs -> CI 🥵 |
* Resolves #34476 There is no maximum length defined in the standard, most common the length is between 128 and 200 characters, but as we store it not in plain data but base64 encoded the length can grow about 1/3. We had a regression with 'Nitrokey 3' which created IDs with 196 byte length -> 262 bytes encoded base64. So to be save we increase the size to 512 bytes. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/47240/stable29
branch
from
4bd1937 to
317c26d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #47240
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.