[stable29] Fix file item display for users with numerical user IDs#48417
Merged
[stable29] Fix file item display for users with numerical user IDs#48417
Conversation
julien-nc
added
bug
2. developing
julien-nc
requested review from
a team,
nfebe,
skjnldsv and
susnux
and removed request for
a team
susnux
approved these changes
Sep 28, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Looks sane, but did not test.
I agree a full backport would make sense, but the sharee title stuff should not be related to the issue (just another issue^^).
…merical user ID Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/stable29/numerical-userid-file-item-display
branch
from
49394cb to
0af3637
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
kyteinsky
approved these changes
Sep 30, 2024
julien-nc
deleted the
fix/stable29/numerical-userid-file-item-display
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial backport of #47287 . I'm not sure it's enough and not sure about the "sharee" part in the
titlefunction.Maybe a full backport would be better than this. Wdyt?
I first saw the issue in 29.0.7 (files displayed as shared by their owner if the user ID is numerical) and checked if it was different in stable29. The issue was still there but not really visible because of the
isExternalcheck that was wrong.To reproduce the issue:
123456789)Check the fix:
123456789user