fix: make federation address book sync work with allow_local_remote_servers = false

[kesselb]

• Resolves: federation address book sync does not work with allow_local_remote_servers = false

Summary

Client.preventLocalAddress expects an absolute URL, which means the base_uri option cannot be used.

Regression from #46002

TODO

• CI
• Review

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[kesselb]

We could also add 'nextcloud' => ['allow_local_address' => true], to always allow private IP ranges for address book federation. But we should also enable it for the initial handshake then, and therefore that's something for a follow-up.

[kesselb]

ClientTest is failing:

1) Test\Http\Client\ClientTest::testPreventLocalAddressDisabledByGlobalConfig with data set #14 ('!@#$', true)
OCP\Http\Client\LocalServerException: Could not detect any host

/home/runner/actions-runner/_work/server/server/lib/private/Http/Client/Client.php:163
/home/runner/actions-runner/_work/server/server/tests/lib/TestCase.php:233
/home/runner/actions-runner/_work/server/server/tests/lib/Http/Client/ClientTest.php:165

2) Test\Http\Client\ClientTest::testPreventLocalAddressDisabledByOption with data set #14 ('!@#$', true)
OCP\Http\Client\LocalServerException: Could not detect any host

/home/runner/actions-runner/_work/server/server/lib/private/Http/Client/Client.php:163
/home/runner/actions-runner/_work/server/server/tests/lib/TestCase.php:233
/home/runner/actions-runner/_work/server/server/tests/lib/Http/Client/ClientTest.php:176

The above URL is invalid, and guzzle/curl will reject it with:

cURL error 3: URL using bad/illegal format or missing URL (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for !@#$

If we keep a16eb6c, then the notable change is that the request is just rejected a bit earlier. Though, it might be nicer to use a different/new exception for it.

Opinions?

[pabzm]

Looks good, thanks! 👍

[kesselb]

/backport 8708164 to stable30

[kesselb]

/backport 8708164 to stable29