chore(profile): move profile app from core to apps#49244
Merged
provokateurin merged 6 commits intomasterfrom Nov 14, 2024
Merged
chore(profile): move profile app from core to apps#49244provokateurin merged 6 commits intomasterfrom
provokateurin merged 6 commits intomasterfrom
Conversation
skjnldsv
added
3. to review
skjnldsv
requested review from
SebastianKrupinski and
hamza221
as code owners
skjnldsv
force-pushed
the
feat/profile-app
branch
3 times, most recently
from
6a22f01 to
c9b63d8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
feat/profile-app
branch
from
b078415 to
c83acf2
Compare
provokateurin
requested changes
Nov 13, 2024
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, just the versions need to be adjusted
skjnldsv
force-pushed
the
feat/profile-app
branch
from
c83acf2 to
a0aaaf2
Compare
provokateurin
approved these changes
Nov 13, 2024
susnux
reviewed
Nov 13, 2024
susnux
reviewed
Nov 13, 2024
skjnldsv
force-pushed
the
feat/profile-app
branch
from
d9909aa to
6201982
Compare
come-nc
approved these changes
Nov 14, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/profile-app
branch
from
6201982 to
5a98533
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
added
4. to release
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #29323
Cleanup core a bit more