[stable30] Bug/48678/restore dav error response by backportbot[bot] · Pull Request #49481 · nextcloud/server

backportbot · 2024-11-25T17:41:55Z

Backport of #49004

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

Review and resolve any conflicts
Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

kesselb · 2024-11-26T12:47:07Z

Conflicts: Constructor property promotion and Imports in Server and ServerFactory

ChristophWurst · 2024-11-26T13:06:26Z

apps/dav/lib/Connector/Sabre/Server.php

+			}
+
+			if ($this->debugExceptions) {
+				$previous = $e;


^ why would Psalm complain here but not on master? Bug?

The psalm run https://github.com/nextcloud/server/actions/runs/12030997029/job/33539600726?pr=49481 does not report it. The reason for this warning could be that #48476 was only done for master, but not backported. However https://github.com/nextcloud/server/actions/runs/12030997029/job/33539601398?pr=49481 does not mention that warning as well. I'm a bit clueless where it comes from ;)

apps/dav/lib/Connector/Sabre/Server.php

+			}
+
+			if ($this->debugExceptions) {
+				$previous = $e;


kesselb · 2024-11-26T14:31:46Z

smb-kerberos-sso seems unrelated and is failing for other stable30 pull requests too.

kesselb

Blocking

apps/dav/lib/Connector/Sabre/Server.php

…eption output" This reverts commit e202896. Signed-off-by: Daniel Kesselberg <[email protected]>

This reverts commit d2bf361. Signed-off-by: Daniel Kesselberg <[email protected]>

This reverts commit 9992e7d. Signed-off-by: Daniel Kesselberg <[email protected]>

Signed-off-by: Daniel Kesselberg <[email protected]>

Signed-off-by: Robin Appelman <[email protected]>

backportbot bot requested review from ChristophWurst, kesselb and miaulalala November 25, 2024 17:41

backportbot bot added bug 3. to review Waiting for reviews feature: dav labels Nov 25, 2024

backportbot bot added this to the Nextcloud 30.0.3 milestone Nov 25, 2024

backportbot bot assigned kesselb Nov 25, 2024

kesselb force-pushed the backport/49004/stable30 branch from daac84a to 4a5de6b Compare November 26, 2024 12:37

github-advanced-security bot found potential problems Nov 26, 2024

View reviewed changes

kesselb marked this pull request as ready for review November 26, 2024 12:49

kesselb requested review from SebastianKrupinski and st3iny as code owners November 26, 2024 12:49

kesselb force-pushed the backport/49004/stable30 branch 2 times, most recently from 0d60beb to 20aada5 Compare November 26, 2024 12:52

miaulalala approved these changes Nov 26, 2024

View reviewed changes

skjnldsv mentioned this pull request Nov 27, 2024

30.0.3 RC1 #49524

Merged

6 tasks

kesselb approved these changes Nov 28, 2024

View reviewed changes

kesselb force-pushed the backport/49004/stable30 branch from 20aada5 to c6395b9 Compare November 28, 2024 09:39

kesselb requested changes Nov 28, 2024

View reviewed changes

kesselb force-pushed the backport/49004/stable30 branch from c6395b9 to a792ed7 Compare November 28, 2024 10:57

come-nc reviewed Nov 28, 2024

View reviewed changes

apps/dav/lib/Connector/Sabre/Server.php Outdated Show resolved Hide resolved

kesselb force-pushed the backport/49004/stable30 branch from a792ed7 to 51b6b9a Compare November 28, 2024 13:32

skjnldsv mentioned this pull request Nov 29, 2024

30.0.3 RC2 #49565

Merged

8 tasks

blizzz mentioned this pull request Dec 5, 2024

30.0.3 #49665

Merged

blizzz modified the milestones: Nextcloud 30.0.3, Nextcloud 30.0.4 Dec 5, 2024

blizzz mentioned this pull request Dec 9, 2024

30.0.4 #49735

Closed

31 tasks

blizzz added this to the Nextcloud 30.0.5 milestone Dec 11, 2024

kesselb mentioned this pull request Dec 22, 2024

Revert: Restore dav error response #49960

Closed

4 tasks

blizzz mentioned this pull request Jan 8, 2025

30.0.5 RC1 #50096

Merged

17 tasks

blizzz modified the milestones: Nextcloud 30.0.5, Nextcloud 30.0.6 Jan 9, 2025

MajorP93 mentioned this pull request Jan 14, 2025

[Bug]: Caldav limit tag on initial sync causes incorrect Caldav error response. #48678

Closed

8 tasks

This was referenced Feb 5, 2025

30.0.6 RC1 #50672

Merged

30.0.6 RC2 #50755

Merged

kesselb force-pushed the backport/49004/stable30 branch from 51b6b9a to be786fc Compare February 11, 2025 12:32

Altahrim mentioned this pull request Feb 12, 2025

30.0.6 #50771

Merged

19 tasks

ChristophWurst approved these changes Feb 12, 2025

View reviewed changes

kesselb force-pushed the backport/49004/stable30 branch 2 times, most recently from fdcda46 to cb8466d Compare February 13, 2025 14:12

kesselb approved these changes Feb 13, 2025

View reviewed changes

Altahrim modified the milestones: Nextcloud 30.0.6, Nextcloud 30.0.7 Feb 13, 2025

SebastianKrupinski approved these changes Feb 13, 2025

View reviewed changes

kesselb force-pushed the backport/49004/stable30 branch from cb8466d to 62f5fa5 Compare February 13, 2025 16:41

kesselb and others added 6 commits February 15, 2025 14:42

Revert "fix: Override start method of \Sabre\DAV\Server to remove exc…

44ad579

…eption output" This reverts commit e202896. Signed-off-by: Daniel Kesselberg <[email protected]>

Revert "fix: Drop unnecessary exit"

cd296eb

This reverts commit d2bf361. Signed-off-by: Daniel Kesselberg <[email protected]>

Revert "fix(dav): Always respond custom error page on exceptions"

e8a5e0c

This reverts commit 9992e7d. Signed-off-by: Daniel Kesselberg <[email protected]>

fix: Replace the TypeError to prevent exposing the installation path

d7b1ecb

Signed-off-by: Daniel Kesselberg <[email protected]>

fix: make locked exception path relative to the view

33fb176

Signed-off-by: Robin Appelman <[email protected]>

fix: use relative paths for upload locks

6cec3ee

Signed-off-by: Robin Appelman <[email protected]>

kesselb force-pushed the backport/49004/stable30 branch from 62f5fa5 to 6cec3ee Compare February 15, 2025 13:42

kesselb merged commit 88b4317 into stable30 Feb 15, 2025
175 checks passed

kesselb deleted the backport/49004/stable30 branch February 15, 2025 15:50

kesselb mentioned this pull request Feb 20, 2025

[Bug]: webdav 404 shows "Internal Server Error" as response #49002

Closed

8 tasks

blizzz mentioned this pull request Mar 4, 2025

30.0.7 RC1 #51241

Merged

13 tasks

lhsei mentioned this pull request Mar 4, 2025

[Bug]: Can't login from iOS client app #50619

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[stable30] Bug/48678/restore dav error response#49481

[stable30] Bug/48678/restore dav error response#49481
kesselb merged 6 commits intostable30from
backport/49004/stable30

backportbot bot commented Nov 25, 2024 •

edited by kesselb

Loading

Uh oh!

kesselb commented Nov 26, 2024

Uh oh!

Check notice

ChristophWurst Nov 26, 2024

Uh oh!

kesselb Nov 26, 2024

Uh oh!

Check notice

kesselb commented Nov 26, 2024

Uh oh!

kesselb left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

backportbot bot commented Nov 25, 2024 • edited by kesselb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Uh oh!

kesselb commented Nov 26, 2024

Uh oh!

Check notice

ChristophWurst Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

kesselb Nov 26, 2024

Choose a reason for hiding this comment

Uh oh!

Check notice

kesselb commented Nov 26, 2024

Uh oh!

kesselb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

backportbot bot commented Nov 25, 2024 •

edited by kesselb

Loading