perf: improve performance of SharedStorage::getWatcher#49569
Merged
Conversation
icewind1991
requested review from
a team,
nfebe,
provokateurin and
yemkareems
and removed request for
a team
4 tasks
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
shared-watcher-perf
branch
from
c7d3fa9 to
bc53a8a
Compare
provokateurin
approved these changes
Nov 29, 2024
artonge
approved these changes
Dec 2, 2024
Contributor
|
/backport to stable30 |
Contributor
|
/backport to stable29 |
Contributor
|
/backport to stable28 |
This was referenced Dec 3, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Merged
Member
|
This PR is causing issues: #50235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of asking the db, use the storage id we already have.