fix(imip): dont compare events for the reply message#51131
Conversation
| case self::METHOD_REPLY: | ||
| $method = self::METHOD_REPLY; | ||
| $data = $this->imipService->buildBodyData($vEvent, $oldVevent); | ||
| $organizerEvent = $this->imipService->getOrganizerVEvent($vEvent->uid, $iTipMessage->recipient); |
There was a problem hiding this comment.
Hey, you can't just pull the event by the recipient, This will fail, for external organizers
|
@SebastianKrupinski would it make sense to keep this even that it only works if the organiser is a local user? |
I don't think having different code paths for internal and external attendees is a good idea, just makes it too complex, the only thing I would keep is the separate method for the reply message, as the reply does not need event comparison, and all the extra information that is normally generate |
2e9dfc5 to
d949cca
Compare
d949cca to
cafd8ad
Compare
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
cafd8ad to
ed1bfe7
Compare
|
/backport to stable30 |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/51131/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ed1bfe70
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51131/stable31Error: Failed to push branch backport/51131/stable31: remote: Invalid username or password. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable31 |
Summary
TODO
Checklist