fix(settings): use correct scope for translations#53695
Merged
Conversation
susnux
requested review from
Altahrim,
icewind1991 and
sorbaugh
and removed request for
a team
susnux
added
bug
3. to review
Contributor
Author
|
/backport to stable31 |
icewind1991
approved these changes
Jun 26, 2025
sorbaugh
approved these changes
Jun 26, 2025
come-nc
reviewed
Jun 26, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
You can use DI and you will get a scoped IL10N instance because you’re in OCA.
susnux
force-pushed
the
fix/settings-l10n
branch
from
973a735 to
8d21c68
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/settings-l10n
branch
from
8d21c68 to
b1282f7
Compare
Contributor
Author
|
/backport to stable30 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The translations are in settings not in core so the scope was set wrong.
Checklist