[stable31] fix(appconfig): mark searchKeys() as internal until 32#54042
Merged
provokateurin merged 1 commit intostable31from Jul 30, 2025
Merged
[stable31] fix(appconfig): mark searchKeys() as internal until 32#54042provokateurin merged 1 commit intostable31from
provokateurin merged 1 commit intostable31from
Conversation
ArtificialOwl
force-pushed
the
fix/noid/mark-searchkeys-as-internal
branch
from
2f03607 to
5e18238
Compare
provokateurin
requested changes
Jul 22, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
The comment @see searchKeys to not load lazy config keys on getKeys should be removed as well.
Member
Author
nice catch |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/mark-searchkeys-as-internal
branch
from
5e18238 to
c15b7aa
Compare
provokateurin
approved these changes
Jul 22, 2025
nfebe
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only for internal uses