Validate filename when creating file from template

[kesselb]

Summary

Validate the filename when creating a file from template.

Steps to reproduce

• Log in as alice
• Open Files
• Click "New" and "New text file"
• Use the filename: bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb.md

Outcome

On most installations this leads to a NotPermittedException exception because the filename is too long for oc_filecache.name. However, on MySQL/MariaDB without strict mode, such a filename is not rejected but truncated.

Jonas and Ferdinand discussed OCP\Files\Folder.newFile not validating the filename in #47563. Would it make sense to add a similar check in assertPathLength to ensure it fits both oc_filecache.path and oc_filecache.name, given the technical limitation of 250 characters?

TODO

• CI
• Review

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[kesselb]

/backport to stable32

[kesselb]

/backport to stable31

[kesselb]

/backport to stable30