fix(shares): Fix infinite loop when all shares are invalid#55813
Merged
fix(shares): Fix infinite loop when all shares are invalid#55813
Conversation
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
Contributor
Author
|
/backport to stable30 |
leftybournes
approved these changes
Oct 20, 2025
Contributor
Author
|
Note: all remnant accounts are listed with "N" in the "Sharer" column, even if they have (hidden) shares. This is because remnants are seen as disabled and their shares deactivated. We should hide the column or fix the value in it. |
provokateurin
approved these changes
Nov 3, 2025
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
9c3a52e to
3e8502d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I do not know if there are other ways to trigger the issue than this one:
occ config:app:set files_sharing hide_disabled_user_shares --value yesocc ldap:check-user <myuser>(turns the user into a remnant)occ ldap:show-remnants-> The command never finishThis is because in commit 8c9aa9a , I made it possible for method checkShare to throw
ShareNotFoundwithout deleting the share.I’m now passing the added count as a reference to the method so that it get decremented if needed only.
Checklist
3. to review, feature component)stable32)