refactor: Separate concerns in link sharing checks #55821
Draft
refactor: Separate concerns in link sharing checks #55821
Conversation
When a logged-in user accesses a public share link in the same browser, the system was incorrectly checking if that user's groups were excluded from creating link shares. This caused share not found errors for users in excluded groups, even though public shares should be accessible to anyone with the link. The group exclusion setting (`shareapi_allow_links_exclude_groups`) is intended to restrict share creation, not share access. Public shares are meant to be anonymous and accessible regardless of the viewer identity or group membership. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Following #55811 split `shareApiAllowLinks()` into two dedicated methods to improve clarity and separation of concerns: - `isLinkSharingEnabled()`: Checks if link sharing is globally enabled - `canUserCreateLinkShares()`: Checks if a user can create link shares (considers both global settings and group restrictions) The original shareApiAllowLinks() is now deprecated and acts as a wrapper to maintain backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #55811 split
shareApiAllowLinks()into two dedicated methods to improve clarityand separation of concerns:
isLinkSharingEnabled(): Checks if link sharing is globally enabledcanUserCreateLinkShares(): Checks if a user can create link shares(considers both global settings and group restrictions)
The original shareApiAllowLinks() is now deprecated and acts as a
wrapper to maintain backward compatibility.