refactor(comment): Port away from deprecated event comment constant#56076
Merged
nickvergessen merged 1 commit intomasterfrom Dec 5, 2025
Merged
refactor(comment): Port away from deprecated event comment constant#56076nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
CarlSchwan
force-pushed
the
carl/cleanup-comment
branch
2 times, most recently
from
ebdab58 to
6ec7466
Compare
CarlSchwan
force-pushed
the
carl/cleanup-comment
branch
from
6ec7466 to
21f4ce9
Compare
CarlSchwan
added
3. to review
CarlSchwan
requested review from
Altahrim,
leftybournes,
salmart-dev and
yemkareems
and removed request for
a team
Create new events to replace deprecated CommentsEvent constant and use them when creating CommentsEvents. On the listener side, we can't yet use these events as deck still send the old events. Also fixes some issues reported by psalm level 3 on the comment app. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/cleanup-comment
branch
from
21f4ce9 to
3c9b937
Compare
nickvergessen
approved these changes
Dec 5, 2025
ChristophWurst
approved these changes
Dec 5, 2025
nickvergessen
added
the
pending documentation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create new events to replace deprecated CommentsEvent constant and use them when creating CommentsEvents.
On the listener side, we can't yet use these events as deck still send the old events.
Also fixes some issues reported by psalm level 3 on the comment app.
TODO
Checklist
3. to review, feature component)stable32)