Skip to content

perf(files): initialize folder tree from current state and store #58273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 6 commits into from
Feb 12, 2026
Merged

perf(files): initialize folder tree from current state and store #58273

AndyScherzinger merged 6 commits into from
Feb 12, 2026
+605 −518

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Feb 11, 2026 •
edited
Loading

Summary

This includes various fixes for the files navigation and folder tree:

  • Files navigation:
    • Only compute views needed for current navigation entry - prevent heavy recomputing trees when new views are registeres
    • Load child views only when needed (shown)
  • Folder tree:
    • If possible load nodes from files store to prevent API calls
    • Register views in batches
    • Do not keep random folders open but default to current path (this reduces API calls on page load)
    • Initialize all shown folders in one API call.
      This reduces API calls from N to 1 when you are in some nested folder because you need not only the children of the root but all siblings of the parents.
      Now this is included in one initial API call.

Checklist

@susnux susnux requested review from a team and skjnldsv as code owners February 11, 2026 22:38
@susnux susnux requested review from a team, CarlSchwan, artonge, icewind1991, leftybournes, nfebe and sorbaugh and removed request for a team February 11, 2026 22:38
@susnux susnux added this to the Nextcloud 34 milestone Feb 11, 2026
@susnux
Copy link
Contributor Author

susnux commented Feb 11, 2026

/backport to stable33

@susnux susnux removed request for a team and skjnldsv February 11, 2026 22:42
@susnux susnux mentioned this pull request Feb 11, 2026
Merged
CarlSchwan
CarlSchwan reviewed Feb 11, 2026
View reviewed changes
@susnux
Copy link
Contributor Author

susnux commented Feb 12, 2026

/compile

susnux and others added 5 commits February 12, 2026 03:31
@susnux
refactor(files): only load navigation views needed
69f2c17 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
perf(files): only emit initialization once
e5c1d80 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
perf(files): initialize folder tree from current path and store
95d7b56 
Initialize the folder tree based on the current directory.
Also only include views needed.

If possible reuse nodes from files store to prevent API call.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@CarlSchwan @susnux
perf(files): Only request directories from the database
0e66ed2 
Signed-off-by: Carl Schwan <[email protected]>
@nextcloud-command @susnux
chore(assets): Recompile assets
e38f96a 
Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger AndyScherzinger merged commit 3d4774e into master Feb 12, 2026
204 of 206 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/folder-tree-2 branch February 12, 2026 06:35
@backportbot backportbot bot mentioned this pull request Feb 12, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: files performance 🚀

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

Tree view improvements

4 participants

@susnux @AndyScherzinger @CarlSchwan @nextcloud-command