Add more checks by nickvergessen · Pull Request #611 · nextcloud/server

nickvergessen · 2016-07-27T14:41:37Z

Todo

Time- and Timezonepicker for Request time
Fix L10N support

MorrisJobke · 2016-07-27T15:15:09Z

apps/workflowengine/js/filesystemtagsplugin.js

+				allowClear: false,
+				multiple: false,
+				placeholder: t('workflowengine', 'Select tag…'),
+				query: _.debounce(function(query) {


Really nice 👍

MorrisJobke · 2016-07-27T15:20:20Z

BUG save without specify an ID results in an uncatched exception:

Der Server hat einen internen Fehler und konnte Ihre Anfrage nicht vervollständigen.

Bitte wenden Sie sich an den Serveradministrator, wenn dieser Fehler mehrfach auftritt, geben Sie bitte die, unten stehenden, technischen Details in Ihrem Bericht mit an.

Weitere Details können im Serverprotokoll gefunden werden.


Technische Details

Entfernte Adresse: ::1
Anfragekennung: 77VouOaOp+LEl/ZmTEoQ
Typ: InvalidArgumentException
Code: 0
Nachricht: Tag id must be integer
Datei: /Users/morrisjobke/Projects/nextcloud/server/lib/private/SystemTag/SystemTagManager.php
Zeile: 99

Ablauf

#0 /Users/morrisjobke/Projects/nextcloud/server/apps/workflowengine/lib/Check/FileSystemTags.php(91): OC\SystemTag\SystemTagManager->getTagsByIds('')
#1 /Users/morrisjobke/Projects/nextcloud/server/apps/workflowengine/lib/Manager.php(281): OCA\WorkflowEngine\Check\FileSystemTags->validateCheck('!is', '')
#2 /Users/morrisjobke/Projects/nextcloud/server/apps/workflowengine/lib/Manager.php(203): OCA\WorkflowEngine\Manager->addCheck('OCA\\WorkflowEng...', '!is', '')
#3 /Users/morrisjobke/Projects/nextcloud/server/apps/workflowengine/lib/Controller/FlowOperations.php(86): OCA\WorkflowEngine\Manager->updateOperation(1, 'asdasd', Array, 'deny')
#4 [internal function]: OCA\WorkflowEngine\Controller\FlowOperations->updateOperation(1, 'asdasd', Array, 'deny')
#5 /Users/morrisjobke/Projects/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php(160): call_user_func_array(Array, Array)
#6 /Users/morrisjobke/Projects/nextcloud/server/lib/private/AppFramework/Http/Dispatcher.php(90): OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\WorkflowEngine\Controller\FlowOperations), 'updateOperation') 
#7 /Users/morrisjobke/Projects/nextcloud/server/lib/private/AppFramework/App.php(111): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\WorkflowEngine\Controller\FlowOperations), 'updateOperation') 
#8 /Users/morrisjobke/Projects/nextcloud/server/lib/private/AppFramework/Routing/RouteActionHandler.php(47): OC\AppFramework\App::main('FlowOperationsC...', 'updateOperation', Object(OC\AppFramework\DependencyInjection\DIContainer), Array) 
#9 [internal function]: OC\AppFramework\Routing\RouteActionHandler->__invoke(Array) 
#10 /Users/morrisjobke/Projects/nextcloud/server/lib/private/Route/Router.php(293): call_user_func(Object(OC\AppFramework\Routing\RouteActionHandler), Array) 
#11 /Users/morrisjobke/Projects/nextcloud/server/lib/base.php(950): OC\Route\Router->match('/apps/workflowe...') 
#12 /Users/morrisjobke/Projects/nextcloud/server/index.php(40): OC::handleRequest() 
#13 {main}

nickvergessen · 2016-07-28T13:10:58Z

apps/workflowengine/js/requesttimeplugin.js

+				return;
+			}
+
+			var placeholder = '["10:00 Europe\\/Berlin","16:00 Europe\\/Berlin"]'; // FIXME need a time picker JS plugin


@MorrisJobke can you help with this maybe? I really suck at such stuff.

nickvergessen · 2016-07-28T13:12:17Z

Pushed again, fixed the exception for missing tag input

MorrisJobke · 2016-07-28T21:07:04Z

I will push my local stuff tomorrow.

nickvergessen · 2016-07-29T08:44:17Z

.htaccess

 </IfModule>
+#### DO NOT CHANGE ANYTHING ABOVE THIS LINE ####
+
+ErrorDocument 403 /server/core/templates/403.php


@MorrisJobke

MorrisJobke · 2016-07-29T08:45:53Z

apps/workflowengine/lib/Check/RequestTime.php

+class RequestTime implements ICheck {
+
+	const REGEX_TIME = '([0-1][0-9]|2[0-3]):([0-5][0-9])';
+	const REGEX_TIMEZONE = '([a-zA-Z]+(?:\\\\\\/[a-zA-Z\-\_]+)+)';


🙈 Just let DateTime parse the time stamp and then handle the exceptions that are thrown. This one here is so error prone.

Normal slashes aren't escaped in JSON BTW ;)

nickvergessen · 2016-08-01T15:58:19Z

Ready to review @MorrisJobke @schiessle

LukasReschke · 2016-08-02T10:14:56Z

apps/workflowengine/lib/Controller/RequestTime.php

+class RequestTime extends Controller {
+
+	/**
+	 * @NoCSRFRequired


MorrisJobke · 2016-08-02T15:19:06Z

Works 👍

nickvergessen · 2016-08-03T12:38:46Z

Counting the resolved comments from Lukas as +1

Add more checks

nickvergessen added enhancement 2. developing Work in progress high feature: workflows labels Jul 27, 2016

nickvergessen added this to the Nextcloud 11.0 milestone Jul 27, 2016

nickvergessen self-assigned this Jul 27, 2016

MorrisJobke reviewed Jul 27, 2016
View reviewed changes

nickvergessen force-pushed the add-more-checks branch from 9a5642a to 008ebd6 Compare July 28, 2016 11:21

nickvergessen mentioned this pull request Jul 28, 2016

Implement missing checks for the workflow engine #617

Closed

11 tasks

nickvergessen force-pushed the add-more-checks branch from 008ebd6 to 4140aea Compare July 28, 2016 13:10

nickvergessen reviewed Jul 28, 2016
View reviewed changes

nickvergessen assigned MorrisJobke Jul 28, 2016

nickvergessen reviewed Jul 29, 2016
View reviewed changes

MorrisJobke force-pushed the add-more-checks branch from f138b3c to 67eb894 Compare July 29, 2016 08:44

MorrisJobke reviewed Jul 29, 2016
View reviewed changes

nickvergessen and others added 12 commits August 1, 2016 17:19

Make sure each plugin is only added once

6430164

Add the systemtag js files

306d725

Add system tag check

c6bf641

Add file size as check

136a1a4

Add file mime type

8a75334

User agent check

477e79c

Add Request URL

1091cbb

Add remote address

2cfd67e

Add request time

e0b5949

add a UI to render proper time picker

2734ff7

Load the timezones via select2

ea4c6bd

Translate the errors

6aa5d67

nickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 1, 2016

nickvergessen force-pushed the add-more-checks branch from b8f47ae to 6aa5d67 Compare August 1, 2016 15:57

nickvergessen added 3 commits August 1, 2016 18:09

Tags need to be loaded before

7c1560d

Allow to define the operation

62d009a

No multi support, less magic

248020f

LukasReschke reviewed Aug 2, 2016
View reviewed changes

Ooops

bcf022c

nickvergessen merged commit 8ad79eb into master Aug 3, 2016

nickvergessen deleted the add-more-checks branch August 3, 2016 12:38

nickvergessen mentioned this pull request Aug 3, 2016

🚧 [WIP] Backport workflow engine 🚧 #602

Merged

2 tasks

GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016

Merge pull request nextcloud#611 from nextcloud/add-more-checks

2a82132

Add more checks

MorrisJobke removed their assignment Sep 5, 2016

Hoerli1337 mentioned this pull request Nov 6, 2017

Internal server error at administration-page #7089

Closed

Uh oh!

Conversation

nickvergessen commented Jul 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Jul 27, 2016 • edited by nickvergessen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented Jul 28, 2016

Uh oh!

MorrisJobke commented Jul 28, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented Aug 1, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MorrisJobke commented Aug 2, 2016

Uh oh!

nickvergessen commented Aug 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nickvergessen commented Jul 27, 2016 •

edited

Loading

MorrisJobke commented Jul 27, 2016 •

edited by nickvergessen

Loading