Change CALDAV to allow calendars be shared with circles.

[viniciuscb]

We've developed a change in the CALENDAR app to allow sharing calendars with circles.

This proposed modification allows that a user can see calendars shared with circles that s/he belongs to.

The modifications in CALENDAR are in the pr:
nextcloud/calendar#602

[mention-bot]

@viniciuscb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @nickvergessen and @georgehrke to be potential reviewers.

[MariusBluem]

@daita

[tcitworld]

See #5638

[ArtificialOwl]

Thanks for the link @tcitworld :)

@viniciuscb Unfortunately, my current work does not take full profit of Circles, as it is only working locally and not using the federated link; meaning you can't share to a remote nextcloud.

If you want to dive into that work, we should arrange a talk somewhere (IRC, telegram, keybase)

[viniciuscb]

Hi @daita my implementation also does not take care of federated circles :-(
We will not use federated circles, at least not at this moment. Is only this that is needed to your PR to enter in master?

Your implementation in #5638 is more complete. We didn't have to change caldav to create a share, only to display a share. Modifications in the calendar app (javascript) were enough to create a 'share to circle' in calendar.

[viniciuscb]

@dtygel

[ArtificialOwl]

I will work on a calendar federated share 'later'. This works fine for local share.

[viniciuscb]

@daita please inform me if you need some help before the feature freeze on friday.

[MorrisJobke]

Moved to 14.

[MorrisJobke]

@daita Please have a look at this

[GoetheG]

Hey @daita, @viniciuscb,

is this feature definitely coming in Nextcloud 14 or should we expect it earlier?

Thank you very much for your contribution, guys!

Yours

[MorrisJobke]

@danxuliu @daita @georgehrke What about this one? It's laying around for quite long already :/

[ArtificialOwl]

let's close this,

[georgehrke]

Why close this?

Shouldn't we implement this feature? Even if it's only for Nextcloud 15?

[georgehrke]

This is good to get in imho:

to test:

• just create a circle.
• for now, check the circle_id in oc_circles_members
• share it:
  curl 'http://nextcloud.local/remote.php/dav/calendars/admin/new-calendar/' -u admin:admin -H 'Content-Type: application/xml; charset=UTF-8' -H 'Accept: */*' -H 'Depth: 0' --data-binary '<x3:share xmlns:x3="http://owncloud.org/ns"><x3:set><x0:href xmlns:x0="DAV:">principal:principals/circles/*circleId*</x0:href></x3:set></x3:share>' --compressed
• make sure it shows up as a calendar for members of the circle.

[MorrisJobke]

Let me fix the phan failures here.

[MorrisJobke]

Let me also fix the dependency injection for the app manager into the Principal. Then I will review this one here.

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

CI fails 🙈

I fixed them in the latest commit. Let's see what CI says.