Merged
Conversation
They should be properly fixed at some point. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr and
nickvergessen
MorrisJobke
reviewed
Mar 22, 2018
| * | ||
| * @suppress PhanDeprecatedFunction | ||
| */ | ||
| public static function checkLoggedIn() { |
MorrisJobke
reviewed
Mar 22, 2018
| * | ||
| * @suppress PhanDeprecatedFunction | ||
| */ | ||
| public static function callCheck() { |
MorrisJobke
reviewed
Mar 22, 2018
| * @deprecated 8.1.0 Use a AppFramework JSONResponse instead | ||
| * @suppress PhanDeprecatedFunction | ||
| */ | ||
| public static function success( $data = array() ) { |
MorrisJobke
reviewed
Mar 22, 2018
| * @deprecated 8.1.0 Use a AppFramework JSONResponse instead | ||
| * @suppress PhanDeprecatedFunction | ||
| */ | ||
| public static function error( $data = array() ) { |
MorrisJobke
reviewed
Mar 22, 2018
| * @deprecated 8.1.0 Use the AppFramework instead. It will automatically check if the app is enabled. | ||
| * @suppress PhanDeprecatedFunction | ||
| */ | ||
| public static function checkAppEnabled( $app ) { |
MorrisJobke
reviewed
Mar 22, 2018
| * @deprecated 8.1.0 Use annotation based ACLs from the AppFramework instead | ||
| * @suppress PhanDeprecatedFunction | ||
| */ | ||
| public static function checkAdminUser() { |
MorrisJobke
reviewed
Mar 22, 2018
This was referenced Mar 22, 2018
MorrisJobke
approved these changes
Mar 22, 2018
juliusknorr
previously requested changes
Mar 22, 2018
| } | ||
|
|
||
| \OCP\JSON::success(array('data' => array('versions' => $versions, 'endReached' => $endReached))); | ||
| \\OC_JSON::success(array('data' => array('versions' => $versions, 'endReached' => $endReached))); |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #8943 +/- ##
============================================
+ Coverage 51.88% 51.89% +0.01%
+ Complexity 25283 25277 -6
============================================
Files 1604 1603 -1
Lines 94918 94906 -12
Branches 1388 1388
============================================
+ Hits 49245 49251 +6
+ Misses 45673 45655 -18
|
MorrisJobke
approved these changes
Mar 23, 2018
juliusknorr
approved these changes
Mar 23, 2018
MorrisJobke
added
4. to release
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should of course be solved properly by moving those functions away from the private class. But I really want to get rid of this in the public interface so nobody that writes app can still use it.