Upgrade to swiftmailer-6 by rullzer · Pull Request #9791 · nextcloud/server

rullzer · 2018-06-07T18:51:05Z

Requires:

Bump swiftmailer/swiftmailer from 5.4.8 to 6.0.2 3rdparty#115

Todo:

Remove php mail mode
- It is removed from swift
- to unreliable
- not enough error info returned
- not properly configured regarding SPF etc 99% of the time
Move mailer over
Fix tests
Add warning to the overview if mail mode is set to php
- Needs If cronErros is empty json_decode will return NULL #9920
Add docs: Update mail documentation documentation#787
Make sure this is in the release notes

MorrisJobke · 2018-06-08T07:49:08Z

Unit tests fail hard :/

rullzer · 2018-06-08T08:02:34Z

Yeah need to fix those as well....

codecov · 2018-06-08T08:27:44Z

Codecov Report

❗ No coverage uploaded for pull request base (master@c92fe76). Click here to learn what that means.
The diff coverage is 73.91%.

@@            Coverage Diff            @@
##             master    #9791   +/-   ##
=========================================
  Coverage          ?   31.71%           
  Complexity        ?    26020           
=========================================
  Files             ?     1661           
  Lines             ?    96178           
  Branches          ?     1291           
=========================================
  Hits              ?    30504           
  Misses            ?    65674           
  Partials          ?        0

Impacted Files	Coverage Δ	Complexity Δ
...tings/templates/settings/admin/additional-mail.php	`0% <ø> (ø)`	`0 <0> (?)`
config/config.sample.php	`0% <0%> (ø)`	`0 <0> (?)`
lib/private/Settings/Admin/Mail.php	`88% <50%> (ø)`	`7 <0> (?)`
core/js/setupchecks.js	`80.27% <50%> (ø)`	`0 <0> (?)`
settings/Controller/CheckSetupController.php	`57.7% <50%> (ø)`	`77 <1> (?)`
lib/private/Mail/Mailer.php	`74.41% <92.85%> (ø)`	`27 <4> (?)`

rullzer · 2018-06-20T07:09:19Z

Should be ready for review.

MorrisJobke · 2018-06-21T21:41:50Z

Make sure this is in the release notes

Please add it to #7827

rullzer · 2018-06-25T06:58:08Z

Done. lets get this in!

MorrisJobke

Tested and works 👍

nickvergessen · 2018-06-25T11:01:20Z

core/js/setupchecks.js

+						messages.push({
+							msg: t(
+								'core',
+								'Use of the the built in php mailer is no longer supported. Please update your e-mail settings.'


I would use a different term then "your email settings", otherwise the admin might be confused and check their personal settings.

nickvergessen · 2018-06-25T11:03:08Z

settings/Controller/CheckSetupController.php

 	}

+	protected function isPhpMailerUsed(): bool {
+		return $this->config->getSystemValue('mail_smtpmode', 'smtp') === 'php';


The default was php, so if it is not set, it used to do php and should also show the warning?

The new default is smtp ;)

exactly, but smtp requires settings, if they are not there emails fail all of a sudden and you dont get a warning because you used the default, so you get "smtp" now and the warning is not displayed

Ah - got it. Yes this need to be changed to php.

nice catch!

nickvergessen · 2018-06-26T12:42:59Z

core/js/setupchecks.js

+						messages.push({
+							msg: t(
+								'core',
+								'Use of the the built in php mailer is no longer supported. Please update your email server settings.'


Could also add a link to the settings, because the messages seem to support html.
Also text suggestion to make clear it's not about the mail server:
Please update the email configuration in the <linky>basic settings<linky>.

good point. Will take care later

Aaah mmm I'm not sure if we can directly link to settings :S

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

* \Swift_Mailer handles starting the transport etc properly * Fixed tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer · 2018-07-04T06:28:50Z

@nickvergessen 👍 ??

nickvergessen

Works

rullzer added enhancement 3. to review Waiting for reviews technical debt labels Jun 7, 2018

rullzer added this to the Nextcloud 14 milestone Jun 7, 2018

rullzer requested review from ChristophWurst, MorrisJobke, blizzz, icewind1991, nickvergessen and skjnldsv June 7, 2018 18:51

rullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 7, 2018

rullzer changed the title ~~3rdparty/noid/bump swiftmailer~~ Upgreade to swiftmailer-6 Jun 8, 2018

rullzer force-pushed the 3rdparty/noid/bump_swiftmailer branch from 52ea2df to e9a6f7e Compare June 8, 2018 12:46

mandree95 mentioned this pull request Jun 14, 2018

SMTP mail with starttls not working if mail server is not supporting TLS1 #7421

Closed

rullzer force-pushed the 3rdparty/noid/bump_swiftmailer branch 3 times, most recently from e2817c6 to bd3d9ab Compare June 19, 2018 18:35

rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 19, 2018

rullzer force-pushed the 3rdparty/noid/bump_swiftmailer branch from bd3d9ab to b6bd2ae Compare June 20, 2018 15:19

MorrisJobke mentioned this pull request Jun 25, 2018

Critical changes for developers & admins for Nextcloud 14 #7827

Closed

rullzer mentioned this pull request Jun 25, 2018

Update mail documentation nextcloud/documentation#787

Closed

MorrisJobke changed the title ~~Upgreade to swiftmailer-6~~ Upgrade to swiftmailer-6 Jun 25, 2018

MorrisJobke approved these changes Jun 25, 2018

View reviewed changes

nickvergessen reviewed Jun 25, 2018

View reviewed changes

rullzer force-pushed the 3rdparty/noid/bump_swiftmailer branch from b6bd2ae to b379bd3 Compare June 25, 2018 18:23

nickvergessen reviewed Jun 26, 2018

View reviewed changes

rullzer force-pushed the 3rdparty/noid/bump_swiftmailer branch from b379bd3 to 2a5b1ae Compare June 26, 2018 14:23

rullzer added 6 commits July 4, 2018 08:28

[3rdparty] Bump swiftmailer 6.0.2

65bcef8

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Kill php mail from settings

0dd4a3e

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Make swift 6 compatible

e6e6b56

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Swift to \Swift_Mailer as abstraction

be7db15

* \Swift_Mailer handles starting the transport etc properly * Fixed tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix settings tests

0cf0bcb

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Add warning to setup checks if the default mailer is still php

6a0c54d

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer force-pushed the 3rdparty/noid/bump_swiftmailer branch from 2a5b1ae to 6a0c54d Compare July 4, 2018 06:28

nickvergessen approved these changes Jul 6, 2018

View reviewed changes

nickvergessen merged commit 3ade347 into master Jul 6, 2018

nickvergessen deleted the 3rdparty/noid/bump_swiftmailer branch July 6, 2018 08:39

kesselb mentioned this pull request Sep 10, 2018

"Use of the the built in php mailer is no longer supported" but SMTP is used #11107

Closed

Uh oh!

Conversation

rullzer commented Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MorrisJobke commented Jun 8, 2018

Uh oh!

rullzer commented Jun 8, 2018

Uh oh!

codecov bot commented Jun 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rullzer commented Jun 20, 2018

Uh oh!

MorrisJobke commented Jun 21, 2018

Uh oh!

rullzer commented Jun 25, 2018

Uh oh!

MorrisJobke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rullzer commented Jul 4, 2018

Uh oh!

nickvergessen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rullzer commented Jun 7, 2018 •

edited

Loading

codecov bot commented Jun 8, 2018 •

edited

Loading