Replace "Active users" and "Shares" charts and replace custom tooltips on Disk chart.#420
Merged
nickvergessen merged 1 commit intomasterfrom Jan 25, 2023
Conversation
JuliaKirschenheuter
requested review from
ChristophWurst,
PVince81,
artonge,
kesselb and
nickvergessen
Member
|
Finally no more weird graphs :D When there are no shares we should however show "something"? |
Collaborator
Author
@kesselb https://github.com/nextcloud/serverinfo/pull/420/files#diff-b86b31801e087ecdaaf18d4d9db5f4362120f71c7173386d118e94b2f1899ac9R275 am i right? |
Member
Collaborator
Author
|
/backport to stable25 |
Collaborator
|
Welcome to the serverinfo team 🥳 |
kesselb
approved these changes
Jan 25, 2023
…place Active users chart with plain information. Replace Shares chart with plain information. Signed-off-by: julia.kirschenheuter <[email protected]>
JuliaKirschenheuter
force-pushed
the
fix/4-Replace_custom_tooltips_with_native_one_for_system_settings_page
branch
from
281c8a4 to
a821953
Compare
nickvergessen
approved these changes
Jan 25, 2023
delete-merged-branch
bot
deleted the
fix/4-Replace_custom_tooltips_with_native_one_for_system_settings_page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #418