Conversation
ernolf
approved these changes
Oct 11, 2024
Contributor
|
@kesselb |
Member
|
@ernolf It is to block merges of PRs too close to release time. 30.0.1 is already frozen (essentially). The check will pass when 30.0.1 is released and the merge will be permitted at that point. If it's a critical fix it can be overridden, but I wouldn't consider this to be critical enough. Short answer: it can be merged when the |
8298606 to
08f0103
Compare
Signed-off-by: ernolf <[email protected]>
08f0103 to
edb9f69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #674