fix(conversations): Remove call-permissions#13086
Merged
nickvergessen merged 3 commits intomainfrom Aug 22, 2024
Merged
Conversation
nickvergessen
added
3. to review
bug
feature: api 🛠️
nickvergessen
changed the title
danxuliu
reviewed
Aug 22, 2024
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
forcePermissions parameter in joinCall should be deprecated, as it is used to set the now deprecated call permissions.
Same for the whole setAllAttendeesPermissions endpoint (which it is in the docs, although it would be good to mark it too in the code documentation so it is picked by OpenAPI).
3 tasks
Member
Author
|
It never made it to the normal docs :D So I will remove it, but not deprecate it (as additional send parameters don't break anyway) |
nickvergessen
force-pushed
the
bugfix/13012/remove-call-permissions
branch
from
d3da61f to
b67edf4
Compare
The permission only existed on API level and it's too complicated to figure out a good UX for it. So the functionality to change it are removed here. It's still kept in the database and response to avoid breakage of existing clients Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/13012/remove-call-permissions
branch
from
b67edf4 to
6f3da72
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
/backport to stable30 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The permission only existed on API level and it's too complicated
to figure out a good UX for it. So the functionality to change it
are removed here. It's still kept in the database and response to
avoid breakage of existing clients
🏁 Checklist
docs/has been updated or is not required