Skip to content

fix(MessageButtonsBar): improve rendering performance#16272

Merged
Antreesy merged 1 commit intomainfrom
fix/noid/message-buttons-always-on
Nov 11, 2025
Merged

fix(MessageButtonsBar): improve rendering performance#16272
Antreesy merged 1 commit intomainfrom
fix/noid/message-buttons-always-on

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 6, 2025

β˜‘οΈ Resolves

  • Always render MessageButtonsBar and Reactions EmojiPicker, get rid of event listeners, rely on CSS instead
  • Replace NcActions with NcButton for less rendering/mounting overload
  • Get rid of event listeners for code blocks, when there is no code blocks

πŸ–ŒοΈ UI Checklist

πŸ–ΌοΈ Screenshots / Screencasts

No visual changes, everything is in performance graph

🚧 Tasks

  • Test in real client

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • πŸ–ŒοΈ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • πŸ“— User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but want to test it tomorrow

@Antreesy Antreesy force-pushed the fix/noid/message-buttons-always-on branch from 2e58b0c to e8f7eee Compare November 7, 2025 10:55
@DorraJaouad
Copy link
Contributor

Changes are fine by me X( testing now

@ShGKme
Copy link
Contributor

ShGKme commented Nov 8, 2025

tomorrow

s/tomorrow/monday

@DorraJaouad
Copy link
Contributor

now

It was indeed now but the approval is not instant for some reasons (conflicts) :3

@Antreesy
Copy link
Contributor Author

General thoughts per commit:

  • 1st should help to speed up a render (so it's just 3 buttons and no popover logic initialised until user clicks), I would definitely keep that βœ…
  • 2 might drop in favor of upstream PR ❌
  • 3 render EmojiPicker for each message with reactions although there are some optimisations done upstream, I'd put in under the table for now ❌
  • 4 might add slight overhead (and would conflict with split chat view work), so I'd extract it to different PR for more precise approach ➑️ 🚧

What are your thoughts, @ShGKme @DorraJaouad ?

@ShGKme
Copy link
Contributor

ShGKme commented Nov 11, 2025

What are your thoughts

πŸ‘

@DorraJaouad
Copy link
Contributor

Fine by me

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/noid/message-buttons-always-on branch from e8f7eee to ada463f Compare November 11, 2025 15:36
@Antreesy Antreesy requested a review from ShGKme November 11, 2025 15:37
@ShGKme
Copy link
Contributor

ShGKme commented Nov 11, 2025

Backport?

@Antreesy
Copy link
Contributor Author

/backport to stable32

@Antreesy Antreesy merged commit 984cf32 into main Nov 11, 2025
56 checks passed
@Antreesy Antreesy deleted the fix/noid/message-buttons-always-on branch November 11, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants