Skip to content

#1424: Add Tables to user_migration#2292

Open
samin-z wants to merge 7 commits intomainfrom
feature/1424-add-table-user-migration
Open

#1424: Add Tables to user_migration#2292
samin-z wants to merge 7 commits intomainfrom
feature/1424-add-table-user-migration

Conversation

@samin-z
Copy link

@samin-z samin-z commented Jan 30, 2026

Add ability to export/import user tables.

@samin-z samin-z changed the title #i424: Add Tables to user_migration #1424: Add Tables to user_migration Jan 30, 2026
$newContext->setName($context['name'] ?? '');
$newContext->setIcon($context['iconName'] ?? '');
$newContext->setDescription($context['description'] ?? '');
$newContext->setOwnerId($context['owner'] ?? '');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we import, do we set the old owner id? Or would be be needed to change this to the current user id of the importer instead? Same probably applies to other importers

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliusknorr this was actually one of the final fixes im making, im going to actually check if the user exist and if not then use current logged in user, what do you think about that? or should we go straight with the current user?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always use the user that is importing as the new owner (as I assume only your own tables/context are exported). The current logged in user may not work as I assume it is importing in a background job?

But I would guess there is a way to get the "target" user as part of the import process of the user_migration app

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understandable, i'm currently working on that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's applied so the new owner is current user.

Comment on lines 87 to 96
public function __construct(
IL10N $l10n,
TableMapper $tableMapper,
ColumnMapper $columnMapper,
RowSleeveMapper $rowSleeveMapper,
ViewMapper $viewMapper,
ContextMapper $contextMapper,
ShareMapper $shareMapper,
ContextNodeRelationMapper $contextNodeRelationMapper,
FavoritesService $favoritesService,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samin-z samin-z marked this pull request as ready for review February 5, 2026 09:36
@samin-z samin-z requested review from blizzz and enjeck as code owners February 5, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants