[stable24] fix: keep menubar in one line - prioritize entries#2313
Merged
juliusknorr merged 3 commits intostable24from Apr 19, 2022
Merged
[stable24] fix: keep menubar in one line - prioritize entries#2313juliusknorr merged 3 commits intostable24from
juliusknorr merged 3 commits intostable24from
Conversation
Menubar entries with submenus cannot be moved to the more-button. Prioritize them when picking the icons for the toolbar. If they still do not fit - do not add them to the more button either they do not work there. This makes sure that the menubar fits in one line and does not overflow. Still prioritizing `undo` and `bold` over `emoji` and `callout`. The former ones are need fairly frequently while the latter not so often. In addition mobile phones have an emoji picker in their text entry. Signed-off-by: Max <max@nextcloud.com>
They cannot be shown in the menu with the remaining tools. Signed-off-by: Max <max@nextcloud.com>
backportbot-nextcloud
bot
requested review from
julien-nc,
max-nextcloud,
mejo- and
vinicius73
Member
|
/compile amend |
When resizing the browser make sure the three dot menu stays on the same line. Without a buffer it would sometimes wrap even though theoretical there was enough space in the menu bar. No idea what is going on there - but a 4px buffer seems to prevent just that. Signed-off-by: Max <max@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/2294/stable24
branch
from
4e9ac95 to
d9d016d
Compare
max-nextcloud
approved these changes
Apr 19, 2022
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Code changes all look good and seem to still apply fine in stable24.
mejo-
approved these changes
Apr 19, 2022
Collaborator
|
@juliushaertl I think you're the only one with the power to merge this. static analysis is failing because dev-stable24 of https://packagist.org/packages/christophwurst/nextcloud has not been released and PR checks are failing because we're in RC times. |
Member
|
psalm shouldn't block the merge, seems drone is still required, though we dropped the CI parts from that. Let me adjust the branch protection rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #2294